Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45777 )
Change subject: soc/intel/icelake/acpi/gpio.asl: Correct GADD method ......................................................................
soc/intel/icelake/acpi/gpio.asl: Correct GADD method
Some cases are inconsistent. Refer to the 495 series on-package PCH to confirm which GPIO pads are the first for each community and fix it.
Change-Id: Ie4c4c12c6629478d754f55fa3fb75fa16eb01335 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/icelake/acpi/gpio.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45777/1
diff --git a/src/soc/intel/icelake/acpi/gpio.asl b/src/soc/intel/icelake/acpi/gpio.asl index 12a4e18..6a8f824 100644 --- a/src/soc/intel/icelake/acpi/gpio.asl +++ b/src/soc/intel/icelake/acpi/gpio.asl @@ -72,13 +72,13 @@ If ((Arg0 >= GPP_G0) && (Arg0 <= GPP_A23)) { Local0 = PID_GPIOCOM0 - Local1 = Arg0 - GPP_A0 + Local1 = Arg0 - GPP_G0 } /* GPIO Community 1 */ If ((Arg0 >= GPP_H0) && (Arg0 <= GPP_F19)) { Local0 = PID_GPIOCOM1 - Local1 = Arg0 - GPP_D0 + Local1 = Arg0 - GPP_H0 } /* GPIO Community 2 */ If ((Arg0 >= GPD0) && (Arg0 <= GPD11))
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45777 )
Change subject: soc/intel/icelake/acpi/gpio.asl: Correct GADD method ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45777 )
Change subject: soc/intel/icelake/acpi/gpio.asl: Correct GADD method ......................................................................
soc/intel/icelake/acpi/gpio.asl: Correct GADD method
Some cases are inconsistent. Refer to the 495 series on-package PCH to confirm which GPIO pads are the first for each community and fix it.
Change-Id: Ie4c4c12c6629478d754f55fa3fb75fa16eb01335 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45777 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/icelake/acpi/gpio.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/icelake/acpi/gpio.asl b/src/soc/intel/icelake/acpi/gpio.asl index 12a4e18..6a8f824 100644 --- a/src/soc/intel/icelake/acpi/gpio.asl +++ b/src/soc/intel/icelake/acpi/gpio.asl @@ -72,13 +72,13 @@ If ((Arg0 >= GPP_G0) && (Arg0 <= GPP_A23)) { Local0 = PID_GPIOCOM0 - Local1 = Arg0 - GPP_A0 + Local1 = Arg0 - GPP_G0 } /* GPIO Community 1 */ If ((Arg0 >= GPP_H0) && (Arg0 <= GPP_F19)) { Local0 = PID_GPIOCOM1 - Local1 = Arg0 - GPP_D0 + Local1 = Arg0 - GPP_H0 } /* GPIO Community 2 */ If ((Arg0 >= GPD0) && (Arg0 <= GPD11))
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)