Attention is currently required from: Frank Chu, Isaac Lee, Tim Wawrzynczak, Zhuohao Lee.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56331 )
Change subject: UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56331/comment/82974e0f_d215b619
PS2, Line 2: FrankChu
Frank Chu
https://review.coreboot.org/c/coreboot/+/56331/comment/a4cd4261_046dcaaa
PS2, Line 7: UPSTREAM:
Please remove.
https://review.coreboot.org/c/coreboot/+/56331/comment/5af51f99_93135ee9
PS2, Line 13: evtest ,SW_PEN_INSERT
Please put the space after the comma.
https://review.coreboot.org/c/coreboot/+/56331/comment/f53c3422_06aabd6c
PS2, Line 15: FrankChu
Frank Chu
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa
Gerrit-Change-Number: 56331
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 15 Jul 2021 09:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment