Attention is currently required from: Raul Rangel. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60281 )
Change subject: util/apcb: Add apcb_v3_edit tool ......................................................................
Patch Set 3:
(5 comments)
This change is ready for review.
File util/apcb/apcb_v3_edit.py:
https://review.coreboot.org/c/coreboot/+/60281/comment/8e938b9b_c24ecdf2 PS2, Line 73: open(args.apcb_in, 'rb')
Done
https://review.coreboot.org/c/coreboot/+/60281/comment/afc738cb_9f18b776 PS2, Line 77: C
Input APCB
Done
https://review.coreboot.org/c/coreboot/+/60281/comment/d0ff2690_1c0fa5d2 PS2, Line 81: fromhex
Need to check the hex argument?
Are you suggesting to check that the hex byte is in range? As is, this will cause an ValueError and cause the build to fail. I can add a try catch and output and more informative error in this case.
https://review.coreboot.org/c/coreboot/+/60281/comment/6b1ff0c1_dc747393 PS2, Line 81: open
`with open()`
Done
https://review.coreboot.org/c/coreboot/+/60281/comment/21d77b30_e1d79942 PS2, Line 82: )
maybe print the file that failed?
Done
-
Rob Barnes (Code Review)