Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85207?usp=email )
Change subject: mb/google/brya: Create uldrenite variant ......................................................................
mb/google/brya: Create uldrenite variant
Create the uldrenite variant of the brya reference board by copying the template files to a new directory named for the variant.
BUG=b:376781355 TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_ULDRENITE
Change-Id: Ife666c6f2fe69643033e2ce3b299e7414e16eef1 Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85207 Reviewed-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-by: Amanda Hwang amanda_hwang@compal.corp-partner.google.com Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/uldrenite/Makefile.mk A src/mainboard/google/brya/variants/uldrenite/gpio.c A src/mainboard/google/brya/variants/uldrenite/include/variant/ec.h A src/mainboard/google/brya/variants/uldrenite/include/variant/gpio.h A src/mainboard/google/brya/variants/uldrenite/memory/Makefile.mk A src/mainboard/google/brya/variants/uldrenite/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/uldrenite/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/uldrenite/overridetree.cb 10 files changed, 107 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Amanda Hwang: Looks good to me, approved Dtrain Hsu: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index c9f7826..6f9f5b5 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -601,6 +601,9 @@ select HAVE_WWAN_POWER_SEQUENCE select INTEL_GMA_HAVE_VBT
+config BOARD_GOOGLE_ULDRENITE + select BOARD_GOOGLE_BASEBOARD_TRULO + config BOARD_GOOGLE_VELL select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -909,6 +912,7 @@ default "Tivviks" if BOARD_GOOGLE_TIVVIKS default "Trulo" if BOARD_GOOGLE_TRULO default "Uldren" if BOARD_GOOGLE_ULDREN + default "Uldrenite" if BOARD_GOOGLE_ULDRENITE default "Vell" if BOARD_GOOGLE_VELL default "Volmar" if BOARD_GOOGLE_VOLMAR default "Xivu" if BOARD_GOOGLE_XIVU @@ -978,6 +982,7 @@ default "teliks" if BOARD_GOOGLE_TELIKS default "trulo" if BOARD_GOOGLE_TRULO default "uldren" if BOARD_GOOGLE_ULDREN + default "uldrenite" if BOARD_GOOGLE_ULDRENITE default "vell" if BOARD_GOOGLE_VELL default "volmar" if BOARD_GOOGLE_VOLMAR default "xivu" if BOARD_GOOGLE_XIVU diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 1beee8d..9bc68bb 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -161,6 +161,9 @@ config BOARD_GOOGLE_ULDREN bool "-> Uldren"
+config BOARD_GOOGLE_ULDRENITE + bool "-> Uldrenite" + config BOARD_GOOGLE_VELL bool "-> Vell"
diff --git a/src/mainboard/google/brya/variants/uldrenite/Makefile.mk b/src/mainboard/google/brya/variants/uldrenite/Makefile.mk new file mode 100644 index 0000000..91f031e --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/Makefile.mk @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-only + +bootblock-y += gpio.c +romstage-y += gpio.c +ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/uldrenite/gpio.c b/src/mainboard/google/brya/variants/uldrenite/gpio.c new file mode 100644 index 0000000..beee6fc --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/gpio.c @@ -0,0 +1,51 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <soc/gpio.h> +#include <types.h> +#include <vendorcode/google/chromeos/chromeos.h> + +/* Pad configuration in ramstage */ +static const struct pad_config gpio_table[] = { + /* TODO */ +}; + +/* Early pad configuration in bootblock */ +static const struct pad_config early_gpio_table[] = { + /* TODO */ +}; + +/* Fill romstage gpio configuration */ +static const struct pad_config romstage_gpio_table[] = { + /* TODO */ +}; + +const struct pad_config *variant_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(gpio_table); + return gpio_table; +} + +const struct pad_config *variant_gpio_override_table(size_t *num) +{ + *num = 0; + return NULL; +} + +const struct pad_config *variant_early_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(early_gpio_table); + return early_gpio_table; +} + +static const struct cros_gpio cros_gpios[] = { + /* TODO */ +}; +DECLARE_CROS_GPIOS(cros_gpios); + +const struct pad_config *variant_romstage_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(romstage_gpio_table); + return romstage_gpio_table; +} diff --git a/src/mainboard/google/brya/variants/uldrenite/include/variant/ec.h b/src/mainboard/google/brya/variants/uldrenite/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/uldrenite/include/variant/gpio.h b/src/mainboard/google/brya/variants/uldrenite/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/uldrenite/memory/Makefile.mk b/src/mainboard/google/brya/variants/uldrenite/memory/Makefile.mk new file mode 100644 index 0000000..d92ecdc --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/memory/Makefile.mk @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/uldrenite/memory src/mainboard/google/brya/variants/uldrenite/memory/mem_parts_used.txt + +SPD_SOURCES = placeholder diff --git a/src/mainboard/google/brya/variants/uldrenite/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/uldrenite/memory/dram_id.generated.txt new file mode 100644 index 0000000..7cbcfb3 --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/memory/dram_id.generated.txt @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Generated by: +# util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/uldrenite/memory src/mainboard/google/brya/variants/uldrenite/memory/mem_parts_used.txt + +DRAM Part Name ID to assign diff --git a/src/mainboard/google/brya/variants/uldrenite/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/uldrenite/memory/mem_parts_used.txt new file mode 100644 index 0000000..2499005 --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.mk and dram_id.generated.txt by running the +# part_id_gen tool from util/spd_tools. +# See util/spd_tools/README.md for more details and instructions. + +# Part Name diff --git a/src/mainboard/google/brya/variants/uldrenite/overridetree.cb b/src/mainboard/google/brya/variants/uldrenite/overridetree.cb new file mode 100644 index 0000000..a5e2217 --- /dev/null +++ b/src/mainboard/google/brya/variants/uldrenite/overridetree.cb @@ -0,0 +1,4 @@ +chip soc/intel/alderlake + device domain 0 on + end +end
-
Subrata Banik (Code Review)