Attention is currently required from: Chen Wisley, Paul Menzel, Angel Pons, Wisley Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56893 )
Change subject: mb/google/brya/variants/redrix: add mipi camera support
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56893/comment/462527ab_25d60100
PS2, Line 128: register "acpi_uid" = "0x50000"
: register "acpi_name" = ""IPU0""
: register "device_type" = "INTEL_ACPI_CAMERA_CIO2"
I don't think this is something that this patch should address.
You are correct Paul, that information could be auto-generated. There is most definitely some work that could be done to clean up the MIPI camera driver, including splitting it up into (at least) sensor, NVM and IPU drivers; fixing the power resources so they do not need reference counting, etc, etc. However, I agree with Angel, it's a separate issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69281f36ddbc1abf9905c8db9287500f9aa995c6
Gerrit-Change-Number: 56893
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment