Attention is currently required from: Raul Rangel, Paul Menzel. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62165 )
Change subject: mb/google/skyrim: Configure WLAN ......................................................................
Patch Set 30:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/be2416de_1c3d72a9 PS30, Line 161: WLAN_DISABLE
Should we set this in the early table as well?
May be needed for boot time later, not needed now.
https://review.coreboot.org/c/coreboot/+/62165/comment/0b012ba7_f3bfa5e2 PS30, Line 180: PAD_NFO
Hrmm, I thought we were deasserting this in the early table.
Needed on previous program due to how interrupts were tied together, but not on Skyrim. May move it in the future to improve boot time.
-
Jon Murphy (Code Review)