Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83773?usp=email )
Change subject: soc/amd/common/include/spi: add and use SPI_MISC_CNTRL defines
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/83773/comment/1f0f2c7c_af5305ce?usp... :
PS1, Line 80: /* Re-purpose unused SPI controller register bit for semaphore to synchronize
: SPI access between SMM and non-SMM software/OS driver. */
: #define SPI_SEMAPHORE_DRIVER_LOCKED BIT(4)
any reason to add this now, rather than in the patch in which it's used? seems unrelated to the MISC […]
no real reason tbh. moving that to CB:83775 would make sense
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I48447dcfb3cee07619a9b42434731f0b21458021
Gerrit-Change-Number: 83773
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 06 Aug 2024 16:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com