Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85127?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 driver ......................................................................
Patch Set 13:
(3 comments)
File src/soc/mediatek/common/include/soc/mt6363.h:
https://review.coreboot.org/c/coreboot/+/85127/comment/ed50d011_cfe25d6c?usp... : PS13, Line 114: pmic_lp_setting remove this if not implemented
File src/soc/mediatek/mt8196/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/78989877_3ec7e81f?usp... : PS7, Line 13: 0
Done
I meant to remove the `shift` field from the `pmic_setting` struct in the header file.
File src/soc/mediatek/mt8196/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/4669e72d_285826e7?usp... : PS13, Line 385: /* TODO: Disable unused modem power in a separate function and Wrong format.
``` /* TODO: ... call that ... */ ```