Attention is currently required from: Paul Menzel.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63713 )
Change subject: mb/google/brya/var/crota: update gpio configuration
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63713/comment/4db81b2f_4b0b7211
PS2, Line 9: enable CPU PCIe VGPIO for PEG60.
: - enable GPP_C3/ GPP_C4 native function.
: - set unused GPIO to NC
Please remove the dots/periods at the end or start the sentences with a capital letter.
Done
https://review.coreboot.org/c/coreboot/+/63713/comment/d7eb5c19_db1db6c7
PS2, Line 15: kernel
Which version?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d4ef92623ce6b0a36e6df23b232b35b498ce964
Gerrit-Change-Number: 63713
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 20 Apr 2022 07:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment