Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
mb/google/dedede: Enable IPU for Wdoo and Wdee variants
IPU is required to be enabled for platform supporting MIPI camera.
IPU is bydefault disabled in devicetree for all variants. Enabling IPU for variants supporting MIPI camera such as Waddledoo, Waddledee and Madoo
BUG=None BRANCH=None TEST=IPU is enabled for platforms and enumerates in lspci.
Change-Id: Ia3cf06d78be4301c68bfa8b1118ddff231d24a66 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb M src/mainboard/google/dedede/variants/waddledee/overridetree.cb M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/44271/1
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 6937338..bccac93 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -45,6 +45,7 @@ }, }" device domain 0 on + device pci 05.0 on end # IPU - MIPI Camera device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on diff --git a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb index b18e589..a538ecc 100644 --- a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb @@ -37,6 +37,7 @@ }"
device domain 0 on + device pci 05.0 on end # IPU - MIPI Camera device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index 3943882..396c4a5 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -50,6 +50,7 @@ }, }" device domain 0 on + device pci 05.0 on end # IPU - MIPI Camera device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 1:
Please rebase on top of parent change
Hello build bot (Jenkins), Krishna P Bhat D, Ronak Kanabar, Aamir Bohra, Divagar Mohandass, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44271
to look at the new patch set (#2).
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
mb/google/dedede: Enable IPU for Wdoo and Wdee variants
IPU is required to be enabled for platform supporting MIPI camera.
IPU is bydefault disabled in devicetree for all variants. Enabling IPU for variants supporting MIPI camera such as Waddledoo, Waddledee and Madoo.
BUG=None BRANCH=None TEST=IPU is enabled for platforms and enumerates in lspci.
Change-Id: Ia3cf06d78be4301c68bfa8b1118ddff231d24a66 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb M src/mainboard/google/dedede/variants/waddledee/overridetree.cb M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/44271/2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 3: Code-Review+2
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44271/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44271/3/src/mainboard/google/dedede... PS3, Line 48: device pci 05.0 on end # IPU - MIPI Camera madoo doesn't support MIPI Camera. Does madoo still need this?
Hello build bot (Jenkins), Krishna P Bhat D, Ronak Kanabar, Aamir Bohra, Divagar Mohandass, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44271
to look at the new patch set (#4).
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
mb/google/dedede: Enable IPU for Wdoo and Wdee variants
IPU is required to be enabled for platform supporting MIPI camera.
IPU is bydefault disabled in devicetree for all variants. Enabling IPU for variants supporting MIPI camera such as Waddledoo, Waddledee and Madoo.
BUG=None BRANCH=None TEST=IPU is enabled for platforms and enumerates in lspci.
Change-Id: Ia3cf06d78be4301c68bfa8b1118ddff231d24a66 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/waddledee/overridetree.cb M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/44271/4
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44271/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44271/3/src/mainboard/google/dedede... PS3, Line 48: device pci 05.0 on end # IPU - MIPI Camera
madoo doesn't support MIPI Camera. […]
No, If Madoo has only USB camera, then its not required. Let me remove this change 😊
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 4:
Requires a rebase on top of parent change.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 5:
Patch Set 4:
Requires a rebase on top of parent change.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@11 PS6, Line 11: Enabling Enable
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@11 PS6, Line 11: bydefault by default
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@13 PS6, Line 13: and Madoo pls remove.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@13 PS6, Line 13: and Madoo
pls remove.
Madoo does not use MIPI camera to my knowledge.
Hello Varshit B Pandya, build bot (Jenkins), Krishna P Bhat D, Aamir Bohra, Ronak Kanabar, Divagar Mohandass, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44271
to look at the new patch set (#7).
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
mb/google/dedede: Enable IPU for Wdoo and Wdee variants
IPU is required to be enabled for platform supporting MIPI camera.
IPU is by default disabled in devicetree for all variants. Enable IPU for Waddledoo and Waddledee supporting MIPI camera.
BUG=None BRANCH=None TEST=IPU is enabled for platforms and enumerates in lspci.
Change-Id: Ia3cf06d78be4301c68bfa8b1118ddff231d24a66 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/waddledee/overridetree.cb M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/44271/7
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@11 PS6, Line 11: bydefault
by default
Done
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@11 PS6, Line 11: Enabling
Enable
Done
https://review.coreboot.org/c/coreboot/+/44271/6//COMMIT_MSG@13 PS6, Line 13: and Madoo
Madoo does not use MIPI camera to my knowledge.
Done
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 7: Code-Review+2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 7: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44271 )
Change subject: mb/google/dedede: Enable IPU for Wdoo and Wdee variants ......................................................................
mb/google/dedede: Enable IPU for Wdoo and Wdee variants
IPU is required to be enabled for platform supporting MIPI camera.
IPU is by default disabled in devicetree for all variants. Enable IPU for Waddledoo and Waddledee supporting MIPI camera.
BUG=None BRANCH=None TEST=IPU is enabled for platforms and enumerates in lspci.
Change-Id: Ia3cf06d78be4301c68bfa8b1118ddff231d24a66 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44271 Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/waddledee/overridetree.cb M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aamir Bohra: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Ronak Kanabar: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb index b18e589..a538ecc 100644 --- a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb @@ -37,6 +37,7 @@ }"
device domain 0 on + device pci 05.0 on end # IPU - MIPI Camera device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index 3943882..396c4a5 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -50,6 +50,7 @@ }, }" device domain 0 on + device pci 05.0 on end # IPU - MIPI Camera device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on
-
Aamir Bohra (Code Review) -
Dtrain Hsu (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Ronak Kanabar (Code Review)