Attention is currently required from: Henry Sun, Yunlong Jia, Bob Moragues.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60130 )
Change subject: UPSTREAM: google/trogdor: Enable Parade ps8640 edp bridge for pazquel
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60130/comment/744e2e12_035504da
PS1, Line 7: UPSTREAM
This *is* upstream. You don't need to write UPSTREAM: in front of patch subjects here.
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60130/comment/a8f4ac47_b824c7f4
PS1, Line 87: 4
Please write as either 0x4 or BIT(2). Also, please put the (... & ...) expression in parenthesis to clarify ordering.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6130ee00a0e6f469142f5416627e38c7b5076071
Gerrit-Change-Number: 60130
Gerrit-PatchSet: 1
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kelsey Wang
peihwang@qualcomm.corp-partner.google.com
Gerrit-CC: Patrick Chang
changp@qualcomm.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 21:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment