Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: Add camera power resource to SSDT
......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41624/25/src/drivers/intel/mipi_cam...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41624/25/src/drivers/intel/mipi_cam...
PS25, Line 20: RCPR
I wonder if this should be called something more generic (e.g. […]
Any 4-uppercase letter name (can include some _) is allowed, as long as it's unique in its scope. Obviously this doesn't always make for very intuitive names for ACPI devices, so I try not to be too picky about those.
If you want to be like the rest of coreboot, the acpi_device_add_power_res() function uses the name "PRIC".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31e198b50acf2c64035aff9cb054fbe3602dd83e
Gerrit-Change-Number: 41624
Gerrit-PatchSet: 25
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kiran2 Kumar
kiran2.kumar@intel.corp-partner.google.com
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-Comment-Date: Tue, 23 Jun 2020 21:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Gerrit-MessageType: comment