Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75860?usp=email )
Change subject: acpi/acpi.c: Fix printing all ACPI tables ......................................................................
acpi/acpi.c: Fix printing all ACPI tables
Loop over tables in xsdt instead of maintaining a list of local variables to loop over. Some tables were not generated directly in the write_acpi_tables function, like IVRS or SRAT. Now those tables are printed too and the code is simpler.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Ie0a6e2b6e2b72b5c8f59e730bea9b51007b507b6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75860 Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Reviewed-by: Marvin Drees marvin.drees@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/acpi/acpi.c 1 file changed, 2 insertions(+), 6 deletions(-)
Approvals: Marvin Drees: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved Felix Held: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index aa1cd1c..78135d7 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -2136,12 +2136,8 @@
if (CONFIG(DEBUG_ACPICA_COMPATIBLE)) { printk(BIOS_DEBUG, "Printing ACPI tables in ACPICA compatible format\n"); - void *acpi_tables[] = { rsdt, xsdt, fadt, facs, slic, ssdt, dsdt, - mcfg, tcpa, tpm2, madt, lpit, bert }; - for (size_t i = 0; i < ARRAY_SIZE(acpi_tables); i++) { - if (acpi_tables[i] == NULL) - continue; - acpidump_print(acpi_tables[i]); + for (size_t i = 0; xsdt->entry[i] != 0; i++) { + acpidump_print((void *)(uintptr_t)xsdt->entry[i]); } printk(BIOS_DEBUG, "Done printing ACPI tables in ACPICA compatible format\n"); }