Attention is currently required from: Bernardo Perez Priego, Jamie Ryu, Jay Patel, Kapil Porwal, Subrata Banik, Tarun Tuli, Wonkyu Kim.
Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email )
Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/75525/comment/18e7988b_51c3796f :
PS6, Line 50: net NC is not present in the given design
SOC_ISH_ACCEL_INT_L
https://review.coreboot.org/c/coreboot/+/75525/comment/ab5a3c82_d91b8ce8 :
PS6, Line 52: net NC is not present in the given design
SOC_ISH_ALS_INT_L
https://review.coreboot.org/c/coreboot/+/75525/comment/f6282fe4_de2f61da :
PS6, Line 58: static const struct pad_config ish_gpp_pads_board2[] = {
Those two are also needed in proto 2.
PAD_CFG_NF(GPP_B08, NONE, DEEP, NF4),
PAD_CFG_NF(GPP_F22, NONE, DEEP, NF8),
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75525?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0f9a7c8318fa9ae59b6f613eafdacbfa07c749
Gerrit-Change-Number: 75525
Gerrit-PatchSet: 6
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jay Patel
jay2.patel@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jay Patel
jay2.patel@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 22:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment