Change in ...coreboot[master]: mb/google/hatch: Enable HUNG_TASK wake interrupt

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Evan Green (Code Review)

20 Mar 2019 20 Mar '19

6:11 p.m.

Evan Green has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32004

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

mb/google/hatch: Enable HUNG_TASK wake interrupt

Enable the HUNG_TASK as a wakeup GPIO, as it's used by S0ix failure detection to wake the system back up if a suspend to S0ix never asserted S0_SLP.

BUG=b:123716513 BRANCH=None TEST=Test S0ix on Hatch with appropriate EC and kernel changes.

Signed-off-by: Evan Green evgreen@chromium.org

Change-Id: I447211892df210af97e8df0380bab032b14cbee8 --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/32004/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h index 10418f4..3aa9414 100644 --- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h @@ -52,7 +52,9 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))

-#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS) +#define MAINBOARD_EC_S0IX_WAKE_EVENTS \ + (MAINBOARD_EC_S3_WAKE_EVENTS | \ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_HANG_DETECT))

/* Log EC wake events plus EC shutdown events */ #define MAINBOARD_EC_LOG_EVENTS \

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Evan Green (Code Review)

20 Mar 20 Mar

6:13 p.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32004 )

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

Patch Set 1:

This is part of EC-based S0ix failure detection and rejection.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Gerrit-Change-Number: 32004 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Comment-Date: Wed, 20 Mar 2019 21:13:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:13 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32004 )

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/32004/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32004/1//COMMIT_MSG@9 PS1, Line 9: wakeup GPIO its actually a host event.

https://review.coreboot.org/#/c/32004/1//COMMIT_MSG@11 PS1, Line 11: S0_SLP nit: SLP_S0#

-- To view, visit https://review.coreboot.org/c/coreboot/+/32004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Gerrit-Change-Number: 32004 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 20 Mar 2019 21:13:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Evan Green (Code Review)

6:24 p.m.

Hello Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32004

to look at the new patch set (#2).

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

mb/google/hatch: Enable HUNG_TASK wake interrupt

Enable the HUNG_TASK as a wakeup host event, as it's used by S0ix failure detection to wake the system back up if a suspend to S0ix never asserted S0_SLP#.

BUG=b:123716513 BRANCH=None TEST=Test S0ix on Hatch with appropriate EC and kernel changes.

Signed-off-by: Evan Green evgreen@chromium.org

Change-Id: I447211892df210af97e8df0380bab032b14cbee8 --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/32004/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Gerrit-Change-Number: 32004 Gerrit-PatchSet: 2 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Evan Green (Code Review)

6:24 p.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32004 )

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/32004/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32004/1//COMMIT_MSG@9 PS1, Line 9: wakeup GPIO

...

its actually a host event.

Ack

https://review.coreboot.org/#/c/32004/1//COMMIT_MSG@11 PS1, Line 11: S0_SLP

...

nit: SLP_S0#

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/32004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Gerrit-Change-Number: 32004 Gerrit-PatchSet: 2 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Mar 2019 21:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:26 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32004 )

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Gerrit-Change-Number: 32004 Gerrit-PatchSet: 2 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 20 Mar 2019 21:26:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

22 Mar 22 Mar

9:17 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32004 )

Change subject: mb/google/hatch: Enable HUNG_TASK wake interrupt ......................................................................

mb/google/hatch: Enable HUNG_TASK wake interrupt

Enable the HUNG_TASK as a wakeup host event, as it's used by S0ix failure detection to wake the system back up if a suspend to S0ix never asserted S0_SLP#.

BUG=b:123716513 BRANCH=None TEST=Test S0ix on Hatch with appropriate EC and kernel changes.

Signed-off-by: Evan Green evgreen@chromium.org

Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32004 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 1 file changed, 3 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

-#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS) +#define MAINBOARD_EC_S0IX_WAKE_EVENTS \ + (MAINBOARD_EC_S3_WAKE_EVENTS | \ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_HANG_DETECT))

/* Log EC wake events plus EC shutdown events */ #define MAINBOARD_EC_LOG_EVENTS \

-- To view, visit https://review.coreboot.org/c/coreboot/+/32004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I447211892df210af97e8df0380bab032b14cbee8 Gerrit-Change-Number: 32004 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1935

days inactive

1937

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Evan Green (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)