Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support ......................................................................
Patch Set 14:
Hi Julius, So this patch is without the interface table support. Only loading the qclib blob. Will add the support for the interface table in later patches. Was planning to add all the relevant structures at that time. Hence trimmed this patch to be minimal like this. Not ok ?
Well... I'm just generally not a fan of landing premature hacks. It's just taking time away from working on the actual fix. You might as well leave this floating until you can clean it up.
Note that this patch also has the same problem in the Makefile as the other one I pointed out anyway. We shouldn't submit those hacks which work around valid build errors, we should rather spend our energy on getting the licensing issues worked out for good.
-
Julius Werner (Code Review)