Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84160?usp=email )
Change subject: tree: Use boolean for lpss_s0ix_enable ......................................................................
tree: Use boolean for lpss_s0ix_enable
lpss_s0ix_enable is already defined as boolean: `git grep lpss_s0ix_enable $(find -type f -name "*.h") src/soc/intel/apollolake/chip.h: bool lpss_s0ix_enable;`
Change-Id: I34bd568defe202daaad6136b9c184bc292a226b3 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/84160 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth gaumless@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb M src/mainboard/google/reef/variants/baseboard/devicetree.cb M src/mainboard/google/reef/variants/coral/devicetree.cb M src/mainboard/google/reef/variants/pyro/devicetree.cb M src/mainboard/google/reef/variants/sand/devicetree.cb M src/mainboard/google/reef/variants/snappy/devicetree.cb M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb 7 files changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index c6bfe54..138499c 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -52,7 +52,7 @@ register "slp_s3_assertion_width_usecs" = "28000"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# Enable DPTF register "dptf_enable" = "1" diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb index 2b3f64c..1192a5f 100644 --- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb @@ -63,7 +63,7 @@ register "hdaudio_bios_config_lockdown" = "1"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb index 80060f1..df39932 100644 --- a/src/mainboard/google/reef/variants/coral/devicetree.cb +++ b/src/mainboard/google/reef/variants/coral/devicetree.cb @@ -63,7 +63,7 @@ register "hdaudio_bios_config_lockdown" = "1"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb index a422b77..022dc8b 100644 --- a/src/mainboard/google/reef/variants/pyro/devicetree.cb +++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb @@ -63,7 +63,7 @@ register "hdaudio_bios_config_lockdown" = "1"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/google/reef/variants/sand/devicetree.cb b/src/mainboard/google/reef/variants/sand/devicetree.cb index b6cf852..f97614d 100644 --- a/src/mainboard/google/reef/variants/sand/devicetree.cb +++ b/src/mainboard/google/reef/variants/sand/devicetree.cb @@ -60,7 +60,7 @@ register "hdaudio_bios_config_lockdown" = "1"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb index c46ca6e..fd30ce7 100644 --- a/src/mainboard/google/reef/variants/snappy/devicetree.cb +++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb @@ -63,7 +63,7 @@ register "hdaudio_bios_config_lockdown" = "1"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb index 294d468..7a46e10 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb +++ b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb @@ -64,7 +64,7 @@ register "hdaudio_bios_config_lockdown" = "1"
# Enable lpss s0ix - register "lpss_s0ix_enable" = "1" + register "lpss_s0ix_enable" = "true"
# GPE configuration # Note that GPE events called out in ASL code rely on this
-
Felix Held (Code Review)