[XS] Change in coreboot[main]: soc/intel/pmclib.c: Work around compiler bug -Werror=stringop-overread - coreboot-gerrit

27 Aug 2024


      Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84042?usp=email )
Change subject: soc/intel/pmclib.c: Work around compiler bug -Werror=stringop-overread
......................................................................
Patch Set 11:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/84042/comment/b20c6ca0_c355ede0?usp... :
PS8, Line 354: 	if (array_size > 0)
...
Hmmm, actually, why not move the check inside `print_num_status_bits()`?
Done differently.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieee6e9bddc4e738eb560dd0e69dc3087ac9f5da6
Gerrit-Change-Number: 84042
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 27 Aug 2024 10:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com