Attention is currently required from: Jérémy Compostella, Martin Roth.
Simon Glass has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/79594?usp=email )
Change subject: Post-build control of serial
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
I'm not sure if this intends to just silence the serial console or all consoles. […]
It is intended to control what coreboot calls the 'interactive console', i.e. one that is sent to the user, normally over a serial port but not always. See console_interactive_tx_byte().
It does not affect writing console output to CBMEM, etc.
CONSOLE_INTERACTIVE_SILENT seems a little long? What do you suggest?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79594?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd867950f117cc6b3dbc582505f3983a0dd714fb
Gerrit-Change-Number: 79594
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 Jul 2024 07:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com