HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44656 )
Change subject: include/asan.h: Add missing includes ......................................................................
include/asan.h: Add missing includes
<stdint.h> and <stddef.h> are missing.
Change-Id: I10520013bb5ceb3aec0d24715f371f77e4300a70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/asan.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/44656/1
diff --git a/src/include/asan.h b/src/include/asan.h index 1fe798d..103fcc9 100644 --- a/src/include/asan.h +++ b/src/include/asan.h @@ -3,6 +3,8 @@ #ifndef __ASAN_H #define __ASAN_H
+#include <types.h> + #define ASAN_SHADOW_SCALE_SHIFT 3
#define ASAN_SHADOW_SCALE_SIZE (1UL << ASAN_SHADOW_SCALE_SHIFT)
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44656 )
Change subject: include/asan.h: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44656 )
Change subject: include/asan.h: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44656 )
Change subject: include/asan.h: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
This unbreaks the tree (tested with unselecting a payload) on ubuntu.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44656 )
Change subject: include/asan.h: Add missing includes ......................................................................
include/asan.h: Add missing includes
<stdint.h> and <stddef.h> are missing.
Change-Id: I10520013bb5ceb3aec0d24715f371f77e4300a70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44656 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Idwer Vollering vidwer@gmail.com --- M src/include/asan.h 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Idwer Vollering: Looks good to me, approved Nico Huber: Looks good to me, approved Felix Held: Looks good to me, approved
diff --git a/src/include/asan.h b/src/include/asan.h index 1fe798d..103fcc9 100644 --- a/src/include/asan.h +++ b/src/include/asan.h @@ -3,6 +3,8 @@ #ifndef __ASAN_H #define __ASAN_H
+#include <types.h> + #define ASAN_SHADOW_SCALE_SHIFT 3
#define ASAN_SHADOW_SCALE_SIZE (1UL << ASAN_SHADOW_SCALE_SHIFT)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44656 )
Change subject: include/asan.h: Add missing includes ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/16068 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16067 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16066 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16065 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16064 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16070 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16069
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Idwer Vollering (Code Review)
-
Nico Huber (Code Review)