[M] Change in coreboot[main]: libpayload/x86: Extend exception handling to x86_64 architecture - coreboot-gerrit

19 Jun 2024


      Attention is currently required from: Arthur Heymans, Julius Werner, Paul Menzel, Subrata Banik.
Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83036?usp=email )
Change subject: libpayload/x86: Extend exception handling to x86_64 architecture
......................................................................
Patch Set 18:
(1 comment)
File payloads/libpayload/arch/x86/exception_asm_64.S:
https://review.coreboot.org/c/coreboot/+/83036/comment/9ae201e8_958ded5e?usp... :
PS16, Line 161: 	push 16(%rax)
              : 	push (%rax)
please add comments for clarity.
same for line#171 and other locations.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83036?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8f0aa1da8d179a760e8d49c3764dfd5a69d06887
Gerrit-Change-Number: 83036
Gerrit-PatchSet: 18
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kapil Porwal kapilporwal@google.com
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 20 Jun 2024 06:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No