Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 )
Change subject: mb/google/guybrush: Enable EC SMI handler ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/ec.c:
https://review.coreboot.org/c/coreboot/+/62599/comment/a9078475_d0927f04 PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI);
Ack. I am not concerned about having the LID_HANDLER event enabled. […]
So doing some more tracing: * https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/plat...
* https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/plat...
depthcharge cleanup handlers that get run when depthcharge shuts down. The SMI handler will run before depthcharge has a chance to processes the lid closed event, so we will not run the cleanup handlers. I think this might cause NVME boot delays as it needs to verify its internal state next boot. IMO, depthcharge should disable the lid closed SMI event regardless of `VB2_GBB_FLAG_DISABLE_LID_SHUTDOWN`. It has code to handle checking it. It could then re-enable it before handing off to the payload just to catch any problems before ACPI is enabled.
-
Raul Rangel (Code Review)