Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Nico Huber.
Saurabh Mishra has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hi Nico, let me replicate on different setup machine, and share you more.
Hi Nico, i am able to replicate the issue.
Test case1: Uisng $(if ,-$(CBFSTOOL) $@.tmp remove -n $(call extract_nth,2,$(file)) 2>/dev/null) Result: Failure UPDATE-FIT Microcode E: Couldn't find microcode blob. make[1]: *** [src/cpu/intel/fit/Makefile.mk:28: add_mcu_fit] Error 1 make: *** [site-local/Makefile.inc:48: board] Error 2
Test Case2: Uisng $(if ,-$(CBFSTOOL) $@.tmp remove -n $(call extract_nth,2,$(file)) 2>/dev/null, ( :) ) Result: Success fallback/postcar 0x1b46c0 stage 31656 none fallback/payload 0x1bc2c0 simple elf 116924 none
Built intel/lnlrvp_dev (lnlrvp)
System Information: Linux cssdesk101 6.8.0-40-generic #40-Ubuntu SMP PREEMPT_DYNAMIC Fri Jul 5 10:34:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
DISTRIB_ID=Ubuntu DISTRIB_RELEASE=24.04 DISTRIB_CODENAME=noble DISTRIB_DESCRIPTION="Ubuntu 24.04 LTS"