Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31927 )
Change subject: util/autoport: fix default headers ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31927/2/util/autoport/bd82x6x.go File util/autoport/bd82x6x.go:
https://review.coreboot.org/#/c/31927/2/util/autoport/bd82x6x.go@309 PS2, Line 309: #include <lib.h> : #include <timestamp.h> : #include <arch/byteorder.h>
Maybe I'm wrong, but I would drop this... […]
It will not complain if these headers are included via some other headers, though.
https://review.coreboot.org/#/c/31927/2/util/autoport/bd82x6x.go@316 PS2, Line 316: #include <cpu/x86/lapic.h> : #include <arch/acpi.h>
also I would drop
Done
https://review.coreboot.org/#/c/31927/2/util/autoport/bd82x6x.go@323 PS2, Line 323: #include <arch/cpu.h> : #include <cpu/x86/msr.h>
and this.
Done
-
Angel Pons (Code Review)