[M] Change in coreboot[main]: acpi/acpigen: Increase max package length for acpigen_pop_len()

[Felix Held (Code Review)]

Attention is currently required from: Cliff Huang, Lance Zhao, Matt DeVillier, Tim Wawrzynczak.

Felix Held has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84192?usp=email )

Change subject: acpi/acpigen: Increase max package length for acpigen_pop_len()
......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2:
> actually, the error turned out to be caused by an extra call to acpigen_pop_len() before the one tha […]

i'd say that this should only be submitted when we need it or get close to needing that, since it'll cause a bit of overhead; that was the reason why i only implemented 3 of the possible 4 cases. not sure though how much overhead that will be.
iirc i wondered if it would be better to start with a 4 byte offset when supporting the 4 length bytes or to keep that 3 bytes and memmove the data one byte when we actually need the 4 length bytes. makes the code a bit more complex though and i haven't benchmarked if that would be worth the additional complexity or not; only benchmarked the 1-3 byte cases

File src/acpi/acpigen.c:

https://review.coreboot.org/c/coreboot/+/84192/comment/f0269347_dfe68383?usp... :
PS2, Line 105: 		/* The case of PkgLength up to 0xfffffff isn't supported at the moment */
that comment isn't true any more after this patch