Change in coreboot[master]: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STOR...
Attention is currently required from: Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 )
Change subject: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STORAGE_HOB2 HOB introduced in FSP 2.3 ......................................................................
Patch Set 5:
(12 comments)
File src/drivers/intel/fsp2_0/hand_off_block.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/286af894_0fc6a74f PS5, Line 320: void* hobPtr = NULL; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/d3be4112_69ce2d53 PS5, Line 322: if (hobPtr != NULL) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/0e225bf6_e2af3b30 PS5, Line 322: if (hobPtr != NULL) { please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/64cb1264_0f65a610 PS5, Line 322: if (hobPtr != NULL) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/2b18d08f_e1c2d555 PS5, Line 323: size = (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_length; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/0bc7a829_0e2fdee2 PS5, Line 323: size = (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_length; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/50c7757d_f673e413 PS5, Line 323: size = (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_length; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/8bbbcd0b_c45c58a1 PS5, Line 323: size = (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_length; spaces prohibited around that '->' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/6ed3789d_a89b560d PS5, Line 324: return (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_ptr; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/5a782b99_1a1090dc PS5, Line 324: return (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_ptr; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/ed7f8902_3df98907 PS5, Line 324: return (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_ptr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134684): https://review.coreboot.org/c/coreboot/+/59638/comment/818683f1_c45fff86 PS5, Line 324: return (fsp_nvs_hob2_data_region_header *) hobPtr-> nvs_data_ptr; spaces prohibited around that '->' (ctx:VxW)
-
build bot (Jenkins) (Code Review)