Attention is currently required from: Andrey Petrov, Felix Held, Felix Singer, Julius Werner, Jérémy Compostella, Martin L Roth, Maximilian Brune, Nico Huber, Ronak Kanabar.
Hello Andrey Petrov, Felix Held, Julius Werner, Jérémy Compostella, Martin L Roth, Maximilian Brune, Ronak Kanabar, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79905?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed: Code-Review+2 by Felix Held, Code-Review+2 by Julius Werner, Code-Review+2 by Maximilian Brune, Verified+1 by build bot (Jenkins)
Change subject: region: Introduce region_create() functions ......................................................................
region: Introduce region_create() functions
We introduce two new functions to create region objects. They allow us to check for integer overflows (region_create_untrusted()) or assert their absence (region_create()).
This fixes potential overflows in region_overlap() checks in SMI handlers, where we would wrongfully report MMIO as *not* overlapping SMRAM.
Also, two cases of strtol() in parse_region() (cbfstool), where the results were implicitly converted to `size_t`, are replaced with the unsigned strtoul().
FIT payload support is left out, as it doesn't use the region API (only the struct).
Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b Ticket: https://ticket.coreboot.org/issues/522 Found-by: Vadim Zaliva lord@digamma.ai Signed-off-by: Nico Huber nico.h@gmx.de --- M src/commonlib/include/commonlib/region.h M src/cpu/x86/smm/smm_module_handler.c M src/cpu/x86/smm/smm_module_loader.c M src/drivers/intel/fsp1_1/fsp_report.c M src/drivers/intel/fsp2_0/fspt_report.c M src/drivers/spi/spi_flash.c M src/drivers/spi/winbond.c M src/include/cpu/x86/smm.h M src/lib/fmap.c M src/soc/qualcomm/common/qclib.c M util/cbfstool/cbfstool.c M util/cbfstool/cse_serger.c 12 files changed, 95 insertions(+), 75 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/79905/9