Attention is currently required from: yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/84200?usp=email )
Change subject: soc/intel/common/systemagent: Add Kconfig item HAVE_TSEG_LIMIT_REGISTER ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84200/comment/62aba1a5_180d2613?usp... : PS1, Line 9: Systemagent assumes GSM region is next to TSEG region, but some SoC may System agent
https://review.coreboot.org/c/coreboot/+/84200/comment/2a8eb766_76227b25?usp... : PS1, Line 11: On such platforms, TSEG region is limited by the TSEG limit register, defined
https://review.coreboot.org/c/coreboot/+/84200/comment/6b353f93_ecd61e4e?usp... : PS1, Line 12: and the default offset for that is (TSEG + 4). I guess you are meaning the register offset of TSEG limit is TSEG base + 4, right?