Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55675 )
Change subject: soc/intel/common/block/cse: Add BWG error recovery to EOP failure
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/55675/comment/373e506c_080b7433
PS12, Line 156: "error\nYour system may be in an insecure state.");
i agree on this, there is no point let system boot to OS with such state or push something like manu […]
PMC IPC will only fail if PMC FW doesn't have the required support added, in such case, can you please make use of https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
"Disable HECI using Sideband interface communication" this is make CSE function disable and device shouldn't list in PCI bus.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06abf36a9d9d8a5f2afba6002dd5695dd2107db1
Gerrit-Change-Number: 55675
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 30 Jun 2021 18:04:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment