Attention is currently required from: Angel Pons, Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nicholas Chin, Nico Huber, Sean Rhodes.
Jean Lucas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS5:
Can you add this to the Kconfig help?
Added a note saying that it should result in lower latency / higher resolution of the timer, not a perf gain.
File src/northbridge/intel/gm45/Kconfig:
https://review.coreboot.org/c/coreboot/+/82000/comment/7d7e0a83_5b4cc2d0 :
PS3, Line 52: config EDK2_USE_LAPIC_TIMER
Uh, sorry, there has been a misunderstanding. […]
Thank you for the clarification. Moved to the CPU Kconfigs.
File src/northbridge/intel/gm45/Kconfig:
https://review.coreboot.org/c/coreboot/+/82000/comment/c14fa14e_9d8c58c1 :
PS5, Line 54: default y
If disabling the Kconfig would break the boot on these platforms, I think `select` is a better optio […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 6
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 18:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jean Lucas
Gerrit-MessageType: comment