Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34811 )
Change subject: Fix superio ......................................................................
Fix superio
Change-Id: I1751c8ef58ccde67aa47bc26abd41a43ddb17bb9 Signed-off-by: Christian Walter christian.walter@9elements.com --- M util/superiotool/aspeed.c 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/34811/1
diff --git a/util/superiotool/aspeed.c b/util/superiotool/aspeed.c index eb047c6..1526d9f 100644 --- a/util/superiotool/aspeed.c +++ b/util/superiotool/aspeed.c @@ -162,7 +162,7 @@ data |= inb((port + 1));
/* Dump val */ - printf("Address %08x\t%08x", (addr), data); + printf("Address %08x\t%08x\n", (addr), data); }
static void dump_registers(uint16_t port, uint32_t base_address) @@ -221,6 +221,11 @@ return i < 0x30; }
+static void dump_pci_id(port) +{ + dump_register(port, AST2400_SUC_BASE_ADDRESS + 0x30); +} + void probe_idregs_aspeed(uint16_t port) { uint16_t chip_id = 0; @@ -242,7 +247,7 @@
enter_conf_mode_ast(port); dump_superio("Aspeed", reg_table, port, chip_id, LDN_SEL); - + dump_pci_id(port); dump_register(port, AST2500_HARDWARE_STRAP_TBL); dump_registers(port, AST2400_SUC_BASE_ADDRESS); exit_conf_mode_ast(port);
Christian Walter has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34811 )
Change subject: Fix superio ......................................................................
Abandoned
Christian Walter has removed Felix Held from this change. ( https://review.coreboot.org/c/coreboot/+/34811 )
Change subject: Fix superio ......................................................................
Removed reviewer Felix Held.