Attention is currently required from: Arthur Heymans, Felix Held, Matt DeVillier.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76500?usp=email )
Change subject: soc/amd/genoa: Add function to fetch common code dt configuration
......................................................................
Patch Set 10:
(1 comment)
File src/soc/amd/genoa/chip.h:
https://review.coreboot.org/c/coreboot/+/76500/comment/dbe30bef_49e85501 :
PS9, Line 12: typedef struct soc_amd_genoa_config config_t;
why is this needed here?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76500?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d5d3ff27ab0953844f9bbef30b6487fb480e29b
Gerrit-Change-Number: 76500
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 27 Sep 2023 16:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment