Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59354 )
Change subject: amdfwtool: Upgrade "relative address" to four address modes ......................................................................
Patch Set 1:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133463): https://review.coreboot.org/c/coreboot/+/59354/comment/a5f42bbc_0049113c PS1, Line 355: ((mode) == 2 ? (offset) - ctx.current_table : (offset)) )) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133463): https://review.coreboot.org/c/coreboot/+/59354/comment/9702331a_f83fe231 PS1, Line 357: #define RUN_TO_OFFSET(ctx, run) ((ctx).address_mode == 0 ? (run) - RUN_BASE(ctx) : (run)) /* TODO: */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133463): https://review.coreboot.org/c/coreboot/+/59354/comment/e5724ef2_184c6bee PS1, Line 478: bdir->header.additional_info_fields.dir_size = table_size / 0x1000;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133463): https://review.coreboot.org/c/coreboot/+/59354/comment/6bc6d738_cbf8e7f8 PS1, Line 955: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133463): https://review.coreboot.org/c/coreboot/+/59354/comment/d9422743_6f4c0323 PS1, Line 961: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133463): https://review.coreboot.org/c/coreboot/+/59354/comment/c9095346_e0d29c69 PS1, Line 974: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
-
build bot (Jenkins) (Code Review)