[L] Change in coreboot[main]: mb/lattepanda: Add support for LattePanda Mu

[Paul Menzel (Code Review)]

Attention is currently required from: Felix Held, KunYi Chen, Nicholas Chin, Nicholas Sudsgaard.

Paul Menzel has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )

Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................

Patch Set 18: Code-Review+1

(13 comments)

Patchset:

PS18: 
Great work!

Commit Message:

https://review.coreboot.org/c/coreboot/+/83719/comment/08c9a444_597f9ec3?usp... :
PS18, Line 11: 8GB LPDDR5 memory
if you have the information, please note the vendor/model too.

https://review.coreboot.org/c/coreboot/+/83719/comment/7e7c078c_0f2daffc?usp... :
PS18, Line 28:   - Windows 11 boot from eMMC
Also install?

https://review.coreboot.org/c/coreboot/+/83719/comment/c9d6a761_3dc56be8?usp... :
PS18, Line 32:   - HDMI output
What about audio? Does it work over HDMI?

https://review.coreboot.org/c/coreboot/+/83719/comment/df0f5009_be65f3e1?usp... :
PS18, Line 33: Realtek Ethernet
Which is it?

https://review.coreboot.org/c/coreboot/+/83719/comment/68d510f8_0fca103f?usp... :
PS18, Line 38: BSOD
It’d be great if you mentioned the “id”/output of the BSOD.

https://review.coreboot.org/c/coreboot/+/83719/comment/c5c82f13_14dc706a?usp... :
PS18, Line 43: 
Do you have some timeing numbers? Vendor firmware until boot loader and coreboot (with MRC cache) until boot loader?

File src/mainboard/lattepanda/mu/bootblock.c:

https://review.coreboot.org/c/coreboot/+/83719/comment/3978f939_bd509a6c?usp... :
PS18, Line 27: UEFITOOLS
UEFITool

https://review.coreboot.org/c/coreboot/+/83719/comment/a32d9b7b_896d2bd6?usp... :
PS18, Line 38: static const struct initdata  it8613e_initdata[]
Just one space after `initdata`.

https://review.coreboot.org/c/coreboot/+/83719/comment/49a57df7_720077c6?usp... :
PS18, Line 64: initdata  it8613e_ecdata[]
Ditto.

https://review.coreboot.org/c/coreboot/+/83719/comment/cb282b4e_87bea9be?usp... :
PS18, Line 95: u16
size_t?

https://review.coreboot.org/c/coreboot/+/83719/comment/95610b00_366e9146?usp... :
PS18, Line 99: u16
`unsigned int` or `size_t`

https://review.coreboot.org/c/coreboot/+/83719/comment/5bc61f9c_3d23abc6?usp... :
PS18, Line 102: if (table[i].OpAnd == 0)
              : 			val = table[i].OpOr;
              : 		else {
              : 			val = ((inb(p_dat) & table[i].OpAnd) |
              : 				table[i].OpOr);
              : 		}
Please use curly brackets for both branches or no brackets.