Attention is currently required from: Furquan Shaikh, Subrata Banik, Andrey Petrov, Patrick Rudolph.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52866 )
Change subject: drivers/intel/fsp2_0: Add mb hooks before & after FSP calls
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/api.h:
https://review.coreboot.org/c/coreboot/+/52866/comment/73a40308_cf39e743
PS1, Line 75: save and restore registers
This seems like a problem with the FSP implementation itself. […]
Sure, but this is being done on the mainboard level, not the platform level. Imagine that you're a developer who doesn't work at Google and can't just get the FSP vendor to fix the issue. What's the recourse?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52866
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc6eb95fa8a1114234cfd7467507992c25669f1
Gerrit-Change-Number: 52866
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 May 2021 15:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment