Attention is currently required from: Hung-Te Lin, Xixi Chen, Yu-Ping Wu. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Get dram size from mtk ddr info or CBMEM_ID_MEMINFO ......................................................................
Patch Set 16:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62065/comment/efbe9b00_3ea7bae6 PS14, Line 10: should update from
calculate it from the mem chip info stored in
Done
https://review.coreboot.org/c/coreboot/+/62065/comment/d0cc4f65_27663cad PS14, Line 13: TEST=Build pass on Kingler
Did you see the correct "dram size: ... […]
Done
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/3d2d7955_8f073020 PS14, Line 16: p
channel
Done
https://review.coreboot.org/c/coreboot/+/62065/comment/fa0f9cc1_bc482938 PS14, Line 17: uint64_t
size_t
Done
https://review.coreboot.org/c/coreboot/+/62065/comment/e1646e17_4f034d60 PS14, Line 20: != NULL
Remove
Done
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/486244cb_d6f1c8a5 PS16, Line 21: ( One space before "("
https://review.coreboot.org/c/coreboot/+/62065/comment/9386ae49_d2378375 PS16, Line 29: { Remove