Jędrzej Ciupis has posted comments on this change by Jędrzej Ciupis. ( https://review.coreboot.org/c/coreboot/+/83884?usp=email )
Change subject: soc/intel/jasperlake: Add CrashLog implementation for Intel JSL ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/jasperlake/crashlog_lib.c:
PS2:
haven't compared this with the code in the other socs, but i wonder if some code in there is actuall […]
Thanks for the comment, it's a fair point. I considered reworking the code when preparing the patch. However, I believe my understanding of this feature is insufficient to redesign it reliably. I wouldn't know if a given code can be made common or rather should be kept separate for forward compatibility and easier extensibility for future SoCs.
Personally, I'd prefer to keep this change as it is and leave such a rework to domain experts from Intel.