Change in coreboot[master]: mb/purism/librem_skl: Disable CLKREQ for NVMe

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Matt DeVillier (Code Review)

15 Jul 2020 15 Jul '20

11:27 p.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

mb/purism/librem_skl: Disable CLKREQ for NVMe

This effectively reverts: 5086ccef [mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe]

Some Librem 15v3/v4 boards are showing issues with NVMe detection or booting via SeaBIOS, so revert this until a proper fix can be found.

Test: build / successfully boot Librem 15v4 with problematic NVMe drive.

Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43490/1

diff --git a/src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb b/src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb index ab46cd3..c8e728c 100644 --- a/src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake

- # Enable CLKREQ# for RP9 - register "PcieRpClkReqSupport[8]" = "1" + # Disable CLKREQ# for RP9 + register "PcieRpClkReqSupport[8]" = "0" # SRCCLKREQ2# for NVMe per schematic register "PcieRpClkReqNumber[8]" = "2"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Angel Pons (Code Review)

16 Jul 16 Jul

1:05 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43490/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43490/1//COMMIT_MSG@10 PS1, Line 10: 5086ccef commit 5086ccef

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 Jul 2020 23:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

3:12 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43490

to look at the new patch set (#2).

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

mb/purism/librem_skl: Disable CLKREQ for NVMe

This effectively reverts commit: 5086ccef [mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe]

Some Librem 15v3/v4 boards are showing issues with NVMe detection or booting via SeaBIOS, so revert this until a proper fix can be found.

Test: build / successfully boot Librem 15v4 with problematic NVMe drive.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43490/2

Paul Menzel (Code Review)

9:20 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43490/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43490/2//COMMIT_MSG@9 PS2, Line 9: commit: : 5086ccef [mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe] If *commit* and the hash are separated by a newline, Gerrit won’t mark it up as a link.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jul 2020 07:20:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

12:39 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43490/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43490/2//COMMIT_MSG@9 PS2, Line 9: commit: : 5086ccef [mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe]

...

If *commit* and the hash are separated by a newline, Gerrit won’t mark it up as a link.

I'd do:

This effectively reverts commit 5086ccef (mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe)

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jul 2020 10:39:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Matt DeVillier (Code Review)

4:33 p.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43490

to look at the new patch set (#3).

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

mb/purism/librem_skl: Disable CLKREQ for NVMe

This effectively reverts commit 5086ccef (mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe).

Some Librem 15v3/v4 boards are showing issues with NVMe detection or booting via SeaBIOS, so revert this until a proper fix can be found.

Test: build / successfully boot Librem 15v4 with problematic NVMe drive.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43490/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

4:34 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43490/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43490/2//COMMIT_MSG@9 PS2, Line 9: commit: : 5086ccef [mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe]

...

I'd do: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jul 2020 14:34:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

4:48 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jul 2020 14:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

4:48 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43490/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43490/1//COMMIT_MSG@10 PS1, Line 10: 5086ccef

...

commit 5086ccef

Done, now people can clicky on the commit message 😄

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jul 2020 14:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Jul 26 Jul

11:30 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43490 )

Change subject: mb/purism/librem_skl: Disable CLKREQ for NVMe ......................................................................

mb/purism/librem_skl: Disable CLKREQ for NVMe

This effectively reverts commit 5086ccef (mb/purism/librem_skl: Fix CLKREQ for 15v3 NVMe).

Some Librem 15v3/v4 boards are showing issues with NVMe detection or booting via SeaBIOS, so revert this until a proper fix can be found.

Test: build / successfully boot Librem 15v4 with problematic NVMe drive.

Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/43490 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/43490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0659f77bbe693f3d3b192a28ff3ef013658930cc Gerrit-Change-Number: 43490 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1630

days inactive

1641

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Matt DeVillier (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)