Attention is currently required from: Arthur Heymans, Lance Zhao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76127?usp=email )
Change subject: acpi/acpi.c: Reduce boilerplate ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76127/comment/8caa8da7_2022cacc : PS1, Line 2053: current += header->length; there is potentially even more commonality that you could add here, e.g.
``` memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); header->revision = get_acpi_table_revision(FADT); memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); ``` most of that could be common here too, but this is still much better than it was