Attention is currently required from: Raul Rangel, Furquan Shaikh, Karthik Ramasubramanian. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52602 )
Change subject: mb/google/mancomb: Enable VBOOT_LID_SWITCH ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52602/comment/7a76a4dc_a3f3444d PS1, Line 13: TEST=Depthcharge no longer halts complaining that coreboot didn't sample : the pin
I like that suggestion.
Thanks for suggestion,I just tried on depthcharge change, but still halt in depthcarge. Did I miss anything? ``` diff --git a/src/board/mancomb/board.c b/src/board/mancomb/board.c index acfa62f6..f4d7b990 100644 --- a/src/board/mancomb/board.c +++ b/src/board/mancomb/board.c @@ -52,6 +52,7 @@ static int board_setup(void) CrosEc *cros_ec = new_cros_ec(&cros_ec_lpc_bus->ops, NULL); register_vboot_ec(&cros_ec->vboot);
+ flag_replace(FLAG_LIDSW, new_gpio_high()); flag_replace(FLAG_PWRSW, cros_ec_power_btn_flag());
SdhciHost *sd = NULL; ```
``` Starting depthcharge on Mancomb... WARNING: can't convert coreboot GPIOs, 'lid' won't be resampled at runtime! src/drivers/gpio/sysinfo.c:47 sysinfo_lookup_gpio(): coreboot did not sample 'lid' GPIO!
```