Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31293
Change subject: arch/x86: Drop some ROMCC remains ......................................................................
arch/x86: Drop some ROMCC remains
Change-Id: I62da8d0461774db8256e82deae0d5fe075f3faed Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/x86/include/arch/io.h 1 file changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/31293/1
diff --git a/src/arch/x86/include/arch/io.h b/src/arch/x86/include/arch/io.h index 4050a47..f62dc6c 100644 --- a/src/arch/x86/include/arch/io.h +++ b/src/arch/x86/include/arch/io.h @@ -203,35 +203,6 @@ } #endif
-/* Conflicts with definition in lib.h */ -#if defined(__ROMCC__) -static inline int log2(u32 value) -{ - unsigned int r = 0; - __asm__ volatile ( - "bsrl %1, %0\n\t" - "jnz 1f\n\t" - "movl $-1, %0\n\t" - "1:\n\t" - : "=r" (r) : "r" (value)); - return r; - -} - -static inline int __ffs(u32 value) -{ - unsigned int r = 0; - __asm__ volatile ( - "bsfl %1, %0\n\t" - "jnz 1f\n\t" - "movl $-1, %0\n\t" - "1:\n\t" - : "=r" (r) : "r" (value)); - return r; - -} -#endif - #ifdef __SIMPLE_DEVICE__
#define PCI_DEV(SEGBUS, DEV, FN) ( \
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31293 )
Change subject: arch/x86: Drop some ROMCC remains ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31293 )
Change subject: arch/x86: Drop some ROMCC remains ......................................................................
arch/x86: Drop some ROMCC remains
Change-Id: I62da8d0461774db8256e82deae0d5fe075f3faed Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/31293 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/include/arch/io.h 1 file changed, 0 insertions(+), 29 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/io.h b/src/arch/x86/include/arch/io.h index 4050a47..f62dc6c 100644 --- a/src/arch/x86/include/arch/io.h +++ b/src/arch/x86/include/arch/io.h @@ -203,35 +203,6 @@ } #endif
-/* Conflicts with definition in lib.h */ -#if defined(__ROMCC__) -static inline int log2(u32 value) -{ - unsigned int r = 0; - __asm__ volatile ( - "bsrl %1, %0\n\t" - "jnz 1f\n\t" - "movl $-1, %0\n\t" - "1:\n\t" - : "=r" (r) : "r" (value)); - return r; - -} - -static inline int __ffs(u32 value) -{ - unsigned int r = 0; - __asm__ volatile ( - "bsfl %1, %0\n\t" - "jnz 1f\n\t" - "movl $-1, %0\n\t" - "1:\n\t" - : "=r" (r) : "r" (value)); - return r; - -} -#endif - #ifdef __SIMPLE_DEVICE__
#define PCI_DEV(SEGBUS, DEV, FN) ( \
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)