Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83939?usp=email )
Change subject: soc/intel/cmn/pmc: Add pmc_ipc to bootblock ......................................................................
soc/intel/cmn/pmc: Add pmc_ipc to bootblock
This adds pmc_ipc to bootblock if SOC_INTEL_COMMON_BLOCK_PMC is enabled. The good place to report SoC QDF can be report_cpu_info in bootblock. QDF read is done by PMC IPC Command, so this adds pmc_ipc to bootblock to enable calling pmc_dump_soc_qdf_info.
Change-Id: Id0391eae48fc53cd652acd09e6380ca6802eaf88 Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83939 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/common/block/pmc/Makefile.mk M src/soc/intel/common/block/pmc/pmc_ipc.c 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/common/block/pmc/Makefile.mk b/src/soc/intel/common/block/pmc/Makefile.mk index e46d5ee..bc60ce5 100644 --- a/src/soc/intel/common/block/pmc/Makefile.mk +++ b/src/soc/intel/common/block/pmc/Makefile.mk @@ -7,5 +7,6 @@ smm-y += pmclib.c verstage-y += pmclib.c postcar-y += pmclib.c +bootblock-$(CONFIG_PMC_IPC_ACPI_INTERFACE) += pmc_ipc.c ramstage-$(CONFIG_PMC_IPC_ACPI_INTERFACE) += pmc_ipc.c endif diff --git a/src/soc/intel/common/block/pmc/pmc_ipc.c b/src/soc/intel/common/block/pmc/pmc_ipc.c index 7c811ae..65b3338 100644 --- a/src/soc/intel/common/block/pmc/pmc_ipc.c +++ b/src/soc/intel/common/block/pmc/pmc_ipc.c @@ -97,6 +97,7 @@ return CB_SUCCESS; }
+#if ENV_RAMSTAGE void pmc_ipc_acpi_fill_ssdt(void) { const struct fieldlist ipcs_fields[] = { @@ -244,3 +245,4 @@ acpigen_write_dword(data[2]); acpigen_write_dword(data[3]); } +#endif