[M] Change in coreboot[master]: [Test] [Do not Merge] soc/intel/cse_lite: Backup PSR data during CSE ...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577 )

Change subject: [Test] [Do not Merge] soc/intel/cse_lite: Backup PSR data during CSE FW downgrade
......................................................................

Patch Set 1:

(10 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/cd1c1040_2213afd8 
PS1, Line 137: #if 0
Consider removing the code enclosed by this #if 0 and its #endif

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/125e8562_754813ef 
PS1, Line 145: #if 0
Consider removing the code enclosed by this #if 0 and its #endif

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/642a124c_b70096fc 
PS1, Line 765: #if 1
Consider removing the #if 1 and its #endif

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/8da2ed45_17bd4bce 
PS1, Line 775: 		if (0x55 != cmos_read(PSR_BACKUP_STATUS_CMOS_OFFSET)) {
Comparisons should place the constant on the right side of the test

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/606133ae_baed56c0 
PS1, Line 777: 			if (CB_SUCCESS == cse_boot_to_rw(cse_bp_info)) {
suspect code indent for conditional statements (24, 40)

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/119d2597_4b20764d 
PS1, Line 777: 			if (CB_SUCCESS == cse_boot_to_rw(cse_bp_info)) {
Comparisons should place the constant on the right side of the test

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/365af231_c6cba3ec 
PS1, Line 788: 				//}	
trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/e462683c_2d37893d 
PS1, Line 875: 	printk(BIOS_DEBUG, "cse_lite: Add elog event \n");
unnecessary whitespace before a quoted newline

File src/soc/intel/common/block/include/intelblocks/cse.h:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/d78d4a2b_e5a31dd5 
PS1, Line 110: #if 1
Consider removing the #if 1 and its #endif

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174607):
https://review.coreboot.org/c/coreboot/+/74577/comment/309acad5_610c6894 
PS1, Line 113: {
open brace '{' following enum go on the same line