Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56882 )
Change subject: mb/google/brya: Configure A17 GPIO to high
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56882/comment/c37c2236_5d1bdbab
PS3, Line 7: Configure A17 GPIO to high
Use 3.3 V for USB UFC
https://review.coreboot.org/c/coreboot/+/56882/comment/8d221883_328805db
PS3, Line 9: Recent change https://review.coreboot.org/c/coreboot/+/56655
As it’s merged already, please reference the commit hash and summary.
https://review.coreboot.org/c/coreboot/+/56882/comment/ee5d263c_475bf30a
PS3, Line 11: probing, however
probing. Hower
https://review.coreboot.org/c/coreboot/+/56882/comment/0493b258_9c37a4c7
PS3, Line 12: by A17, this caused USB UFC enumeration to fail
Please add dot/period at the end of sentences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c204ec07b1f7511f0d88074e336cfc9116a7d2
Gerrit-Change-Number: 56882
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment