Change in coreboot[master]: rivers/spi/spi_flash.c: Remove unused <boot_device.h>

List overview All Threads
Download

newer

older

Change in coreboot[master]: src:...

HAOUAS Elyes (Code Review)

29 Sep 2020 29 Sep '20

1:22 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45817 )

Change subject: rivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

rivers/spi/spi_flash.c: Remove unused <boot_device.h>

Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/spi/spi_flash.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/45817/1

diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index f2610a1..66804ec 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */

#include <assert.h> -#include <boot_device.h> #include <boot/coreboot_tables.h> #include <console/console.h> #include <string.h>

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by thread

HAOUAS Elyes (Code Review)

29 Sep 29 Sep

1:23 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45817 )

Change subject: rivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45817/1/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:

https://review.coreboot.org/c/coreboot/+/45817/1/src/drivers/spi/spi_flash.c... PS1, Line 91: ASAP! hmmm?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Gerrit-Change-Number: 45817 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Tue, 29 Sep 2020 11:23:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

23 Jan 23 Jan

3:30 p.m.

New subject: Change in coreboot[master]: drivers/spi/spi_flash.c: Remove unused <boot_device.h>

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45817

to look at the new patch set (#4).

Change subject: drivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

drivers/spi/spi_flash.c: Remove unused <boot_device.h>

Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/spi/spi_flash.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/45817/4

Angel Pons (Code Review)

31 Jan 31 Jan

12:42 p.m.

New subject: Change in coreboot[master]: drivers/spi/spi_flash.c: Remove unused <boot_device.h>

Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45817 )

Change subject: drivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

Patch Set 6:

(1 comment)

File src/drivers/spi/spi_flash.c:

https://review.coreboot.org/c/coreboot/+/45817/comment/13d31d89_9150b6ca PS6, Line 4: #include <boot/coreboot_tables.h> #include <commonlib/region.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/45817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Gerrit-Change-Number: 45817 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Sun, 31 Jan 2021 11:42:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:39 p.m.

New subject: Change in coreboot[master]: drivers/spi/spi_flash.c: Remove unused <boot_device.h>

Attention is currently required from: HAOUAS Elyes. Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45817

to look at the new patch set (#8).

Change subject: drivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

drivers/spi/spi_flash.c: Remove unused <boot_device.h>

Also add missing <commonlib/region.h>.

Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/spi/spi_flash.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/45817/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/45817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Gerrit-Change-Number: 45817 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1 Feb 1 Feb

1:45 p.m.

New subject: Change in coreboot[master]: drivers/spi/spi_flash.c: Remove unused <boot_device.h>

Attention is currently required from: Angel Pons. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45817 )

Change subject: drivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

Patch Set 8:

(1 comment)

File src/drivers/spi/spi_flash.c:

https://review.coreboot.org/c/coreboot/+/45817/comment/b9db3d17_da834128 PS6, Line 4: #include <boot/coreboot_tables.h>

...

#include <commonlib/region. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Gerrit-Change-Number: 45817 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 01 Feb 2021 12:45:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8 Feb 8 Feb

3:39 p.m.

New subject: Change in coreboot[master]: drivers/spi/spi_flash.c: Remove unused <boot_device.h>

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45817 )

Change subject: drivers/spi/spi_flash.c: Remove unused <boot_device.h> ......................................................................

Abandoned

see 50201

-- To view, visit https://review.coreboot.org/c/coreboot/+/45817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f6a5df455dff8bfdd9940b10bdbfd73454bc881 Gerrit-Change-Number: 45817 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: abandon

1184

days inactive

1316

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)