Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Sridhar Siricilla.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM
......................................................................
Patch Set 19:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/c3a80a97_ae92d17e
PS16, Line 1250: if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && !s3wake) {
: timestamp_add_now(TS_CSE_FW_SYNC_START);
: cse_fw_sync();
: timestamp_add_now(TS_CSE_FW_SYNC_END);
:
: if (CONFIG(SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION))
: store_cse_rw_fw_version();
: }
: }
@Arthur, would you mind to take a look into this cl and share your comments based on the above response. We are in a little time sensitive zone with this cl and would like to enable this feature ASAP. looking forward to get your support
The code in ramstage_cse_fw_sync() is so similar to ramstage_store_cse_fpt_info() that it would make sense to unify it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8
Gerrit-Change-Number: 74256
Gerrit-PatchSet: 19
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 08:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment