Attention is currently required from: Paul Menzel, Angel Pons, Patrick Rudolph. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59527 )
Change subject: mb/lenovo: Enable MEI on Sandy Bridge ThinkPads ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59527/comment/188760b8_d092a6df PS2, Line 7: Sandy Bridge
Strictly speaking, this should be `Cougar Point`, the PCH. […]
I know. I even did it on T420, a long time ago. But it became a common practice to refer to xx20 series of ThinkPads as "Sandy Bridge ThinkPads", and to xx30 series as "Ivy Bridge ThinkPads". Even our documentation does so (https://doc.coreboot.org/mainboard/index.html#lenovo). So I decided to keep the style and be consistent.
https://review.coreboot.org/c/coreboot/+/59527/comment/5ba2da23_a99d880e PS2, Line 12: 0793afe9
commit 0793afe9 (mb/lenovo/x220: disable ME)
Done
https://review.coreboot.org/c/coreboot/+/59527/comment/ed3d8ca0_b604cb70 PS2, Line 12: 0793afe9
commit 0793afe9 (mb/lenovo/x220: disable ME)
Done
https://review.coreboot.org/c/coreboot/+/59527/comment/08c6df92_7dfdfb73 PS2, Line 13: today
With which Linux kernel version?
Done
https://review.coreboot.org/c/coreboot/+/59527/comment/fd250a69_2bd6995a PS2, Line 15: Also: : - it breaks the me_disable feature, : - we already have a Kconfig option to hide MEI in case of errors, : - it will be hidden on disabled, recovery, firmware update paths anyway.
I'd convert this list of reasons into a paragraph.
Done
-
Evgeny Zinoviev (Code Review)