Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal, Nick Vaccaro.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70262 )
Change subject: drivers/wifi/generic: Fix properties in generic-under-PCI device case ......................................................................
Patch Set 4:
(1 comment)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/70262/comment/8870c42c_8a73f1b4 PS4, Line 585: wifi_pcie_fill_ssdt `wifi_pcie_fill_ssdt` should only be used for PCIe wifi, e.g. ``` device ref pcie_rp4 on # PCIe 4 WLAN register "pch_pcie_rp[PCH_RP(4)]" = "{ .clk_src = 2, .clk_req = 2, .flags = PCIE_RP_LTR | PCIE_RP_AER, }" chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" register "add_acpi_dma_property" = "true" device pci 00.0 on end end end ```
For the devicetree snippet in your commit message, it should be using `wifi_cnvi_fill_ssdt`. I.e. `wifi_generic_enable` should return `wifi_cnvi_ops`. Could you check why that's not happening?