[XS] Change in coreboot[master]: mb/google/skyrim/variants/baseboard:Update system_configuration

[Paul Menzel (Code Review)]

Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Tim Van Patten.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/google/skyrim/variants/baseboard:Update system_configuration
......................................................................

Patch Set 2:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76091/comment/bcbeac04_dd8ccb6d :
PS2, Line 7: :Update
Please add a space.

https://review.coreboot.org/c/coreboot/+/76091/comment/ea1f429f_70e3e8e8 :
PS2, Line 7: system_configuration
That parameter name seems too generic.

https://review.coreboot.org/c/coreboot/+/76091/comment/49e96d9b_7296f1d9 :
PS2, Line 7: mb/google/skyrim/variants/baseboard:Update system_configuration
Maybe more specific:
> mb/google/skyrim: Set system_configuration = 4 to avoid SMU call

https://review.coreboot.org/c/coreboot/+/76091/comment/4293ad27_97610df8 :
PS2, Line 10: "
Is that quote in there?

https://review.coreboot.org/c/coreboot/+/76091/comment/62993b9b_1974f823 :
PS2, Line 12: that is not needed
Is that causing some delay, or it’s just for correctness?

https://review.coreboot.org/c/coreboot/+/76091/comment/d4d8a5b1_0fc6b1cf :
PS2, Line 15: TEST=Confirm extra message is not sent in serial log.
Could you please paste the message that is not sent?