[XS] Change in coreboot[main]: mb/google/brox: Remove ACPI Power Resource for Bluetooth device

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84135?usp=email )

Change subject: mb/google/brox: Remove ACPI Power Resource for Bluetooth device
......................................................................

mb/google/brox: Remove ACPI Power Resource for Bluetooth device

Bluetooth driver in kernel requires reset-gpio in current resource
settings (_CRS) and device specific data (_DSD) ACPI objects. Hence
remove ACPI Power Resource for Bluetooth device so that the concerned
ACPI objects get populated.

BUG=b:362817900
TEST=Build Brox Firmware image and boot to OS. Ensure that the _CRS and
_DSP ACPI objects are filled in the SSDT with the required data.

Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
{
    GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
        "\_SB.PCI0.GPIO", 0x00, ResourceConsumer, ,
        )
        {   // Pin list
            0x004D
        }
})
Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
{
    ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
    Package (0x01)
    {
        Package (0x02)
        {
            "reset-gpio",
            Package (0x04)
            {
                _SB.PCI0.XHCI.RHUB.HS10,
                Zero,
                Zero,
                One
            }
        }
    }
})

Change-Id: If6e679aa3f4181e7963ac53d0847b1512959b3a7
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84135
Reviewed-by: Bob Moragues 
Tested-by: build bot (Jenkins) 
Reviewed-by: Ren Kuo 
---
M src/mainboard/google/brox/variants/brox/overridetree.cb
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
M src/mainboard/google/brox/variants/lotso/overridetree.cb
3 files changed, 0 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Bob Moragues: Looks good to me, but someone else must approve
  Ren Kuo: Looks good to me, approved

diff --git a/src/mainboard/google/brox/variants/brox/overridetree.cb b/src/mainboard/google/brox/variants/brox/overridetree.cb
index 37c4e01..f2342f0 100644
--- a/src/mainboard/google/brox/variants/brox/overridetree.cb
+++ b/src/mainboard/google/brox/variants/brox/overridetree.cb
@@ -247,7 +247,6 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Bluetooth""
    					register "type" = "UPC_TYPE_INTERNAL"
-						register "has_power_resource" = "1"
    					register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)"
    					device ref usb2_port10 on end
    				end
diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
index bd7fca0..d1fbb8b 100644
--- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb
+++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
@@ -203,7 +203,6 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Bluetooth""
    					register "type" = "UPC_TYPE_INTERNAL"
-						register "has_power_resource" = "1"
    					register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)"
    					device ref usb2_port10 on end
    				end
diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb
index e81848d..0f87889 100644
--- a/src/mainboard/google/brox/variants/lotso/overridetree.cb
+++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb
@@ -302,7 +302,6 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Bluetooth""
    					register "type" = "UPC_TYPE_INTERNAL"
-						register "has_power_resource" = "1"
    					register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)"
    					device ref usb2_port10 on end
    				end